[Webkit-unassigned] [Bug 36177] [Qt] Multiselect Popup - Listbox click simulation

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 16 14:25:50 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=36177





--- Comment #3 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2010-03-16 14:25:50 PST ---
(From update of attachment 50832)

> +void HTMLSelectElement::listBoxPopupClick(int listIndex, bool multi, bool shift, bool fireEvents)
> +{
> +    if (!multiple())
> +        setSelectedIndexByUser(listIndex, true, fireEvents);
> +    else {
> +        updateSelectedState(m_data, this, listIndex, multi, shift);
> +        if (fireEvents)
> +            listBoxOnChange();
> +    }
> +}

I don't really know this code so I might be wrong, but the true in
setSelectedIndexByUser is for deselect, so I would guess that
updateSelectedState might be calling this method.

Maybe it makes more sense to modify updateSelectedState to do the (!multiple())
check?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list