[Webkit-unassigned] [Bug 36190] New: WinCairo Build Broken Due To Include Path Fragility

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36190

           Summary: WinCairo Build Broken Due To Include Path Fragility
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Windows 7
            Status: NEW
          Severity: Critical
          Priority: P2
         Component: WebCore Misc.
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: bfulgham at webkit.org


The use of the common file name "FontPlatformData.h" across multiple platforms
means that the ordering of include paths determines which version of this file
is used during a build.

A recent source change (http://trac.webkit.org/changeset/55510) broke the
WinCairo build because it moved the Gtk-specific version of FontPlatformData.h
into the platform/graphics/cairo directory, which is now used preferentially to
the historical version in platform/graphics/win.

After discussing the issue with Adam Roben, we decided that the best long-term
solution is to rename this header file 'FontPlatformDataWin.h', to disambiguate
the file intended for the build.

The attached patch makes this proposed change.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.