[Webkit-unassigned] [Bug 32290] [GTK] can't input korean into lower all input box except adress input box in webkit gtk launcher

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32290


Xan Lopez <xan.lopez at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50775|review?                     |review+
               Flag|                            |




--- Comment #37 from Xan Lopez <xan.lopez at gmail.com>  2010-03-16 01:27:42 PST ---
(From update of attachment 50775)
>-static void setPendingComposition(gchar* newComposition)
>+static void imContextCommitted(GtkIMContext* context, const gchar* compositionString, EditorClient* client)
> {
>-    g_free(pendingComposition);
>-    pendingComposition = newComposition;
>-}
>+    // If this signal fires during a keydown event when we are not in the middle
>+    // of a composition, then treat this 'commit' as a normal key event and just
>+    // change the editable area right before the keypress event.
>+    if (client->treatContextCommitAsKeyEvent()) {
>+        client->updatePendingComposition(compositionString);
>+        return;
>+    }
> 
>-static void setPendingPreedit(gchar* newPreedit)
>-{
>-    g_free(pendingPreedit);
>-    pendingPreedit = newPreedit;
>-}
>+    Frame* frame = core(client->webView())->focusController()->focusedOrMainFrame();
>+    if (!frame || !frame->editor()->canEdit())
>+        return;

I thought we had decided to move this check to the beginning of the function?
Did you forget or have you found any problems with that?

It looks fine to me other than that, so r=me with that change unless you have a
good reason not to do it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.