[Webkit-unassigned] [Bug 36155] Let commit-queue land rollout patches even when the tree is red

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 15 22:49:46 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=36155


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50762|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #2 from Eric Seidel <eric at webkit.org>  2010-03-15 22:49:46 PST ---
(From update of attachment 50762)
Use a constant:
 101         return self.name().startswith("ROLLOUT ")

This is no where near 80c:
 154         valid_patches =
self.committer_validator.patches_after_rejecting_invalid_commiters_and_reviewers(all_patches)

You haz made the uglies!
186         if not patch.is_rollout() and (not self._builders_are_green() or
not self._can_build_and_test() or not self._builders_are_green()):

patch?
 52     "name": "Path1",

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list