[Webkit-unassigned] [Bug 36006] Multiselect popups

Mon Mar 15 21:49:08 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=36006

Kenneth Rohde Christiansen <kenneth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50683|review?                     |review-
               Flag|                            |

--- Comment #7 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2010-03-15 21:49:08 PST ---
(From update of attachment 50683)

> Adding a compile time flag that when used do:
> 
> * force all <select> elements to use popups.
> * adjust Qt rendering of the new combo elements.
> * provide information to QStyle objects to differentiate beetwing normal combos and
>   the new multiselect combos.

I guess other platforms might want to use something similar, so maybe it is a
better idea to introduce a generic flag and combine it with PLATFORM(QT) if
needed?

ENABLE_NO_LISTBOXES also doesn't sound very Qt dependent, and from looking at
the code it isn't so I would suggest you refrase yourself a bit in the
ChangeLog.

Also I dislike the name;  Enabling a disabler sounds strange to me :-) or maybe
find a better name. ENABLE(TOUCHABLE_SELECTORS) maybe?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.