[Webkit-unassigned] [Bug 36141] Fix webkit win test failures for smart delete

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36141





--- Comment #3 from Ojan Vafai <ojan at chromium.org>  2010-03-15 16:51:45 PST ---
(In reply to comment #2)
> (From update of attachment 50743 [details])
> Is doubleClickAtSelectionStart() used in any other tests?

Yes.

> Does it misbehave in those?

Doesn't seem to. I haven't dug enough to really understand what the underlying
issue is, so it's hard to say whether all cases of doubleClickAtSelectionStart
could have this problem.

> Would it be a good idea to change it instead, adding 1 pixel to
> coordinates?

I can certainly do that. I considered it, but it seemed a bit strange given
that a collapsed selection is zero-width. In either case, I was going for the
minimal change that would green the tree.

> I was going to say r=me, but then realized that I don't understand why Mac test
> results changed.

Yeah, it took me a minute to make sense of that as well. I'm pretty sure what's
happening is that the initial click of the double click is now moving the
selection and the second click is selecting the word. Before, the initial click
was in the same place as the caret, so there was no selection change.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.