[Webkit-unassigned] [Bug 34912] audio engine: add ReverbConvolver class

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34912





--- Comment #8 from Chris Rogers <crogers at google.com>  2010-03-15 16:23:51 PST ---
Hi Jeremy, thanks very much for your review!

I tried carefully to address your style comments, but you can check and maybe
you'll find a few more :)

You had two more complex questions which I'll try to address:

> How was this measured?  On what platforms?  How will we make sure that this
> stays close to reality?  (I.e. can we make a layout test that verifies this or
> something?)

I added some more comments here.  Later on in the code I had a block which
was #if 0 for testing which could at some point be part of a test to make sure
the background thread is working properly.  For now I've removed this "dead"
code.  For a layout test, we would have to create a "special" testing
javascript API which could report any problems back.  Or maybe there's a
simpler way...


> Is any such "command line tool" intended to be upstreamed?  If not, this
> support should be removed.

I believe that we should, since the tools are very important for any javascript
developers wanting to create their own custom impulse responses.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.