[Webkit-unassigned] [Bug 18282] WebKit crashes with deeply nested divs

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 15 12:57:14 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=18282





--- Comment #21 from Eric Seidel <eric at webkit.org>  2010-03-15 12:57:12 PST ---
(From update of attachment 50688)
Does Chromium want this?

Aren't ports going to want to control MAX_DOM_TREE_DEPTH?  I guess they can
already by setting both ENABLE and MAX_DOM_TREE_DEPTH.

The implementation looks OK.

Are you sure this is the order you want?
+#if ENABLE(DOMTREE_PARSING_MAXDEPTH)
+    if (m_nodeDepth > MAX_DOM_TREE_DEPTH)
+        return;
+#endif
     exitText();

+        handleError(nonFatal, "Too deep tree.", lineNumber(), columnNumber());

"DOM tree is too deep" would be more clear to my eyes.  What sort of message
does FireFox provide here?  I'm pretty sure they have a limit.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list