[Webkit-unassigned] [Bug 33413] selection.modify extends too far with 'lineboundary'

Mon Mar 15 00:11:41 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=33413

Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50687|review?                     |review+
               Flag|                            |

--- Comment #25 from Alexey Proskuryakov <ap at webkit.org>  2010-03-15 00:11:41 PST ---
(From update of attachment 50687)
> +            // LineBoundary granularity emulates
> +            // [NSTextView moveToRightEndOfLineAndModifySelection:].

You didn't fully address my comments here - it's better to talk about
user-visible behavior than about low level methods, and the dash sign is an
integral part of method name. I still think we'd be better without any comment.

r=me

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.