[Webkit-unassigned] [Bug 36095] REGRESSION(r53287): drop event is not fired if dataTransfer.dropEffect is not explicitly set

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36095


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50679|review?                     |review+
               Flag|                            |




--- Comment #7 from Darin Adler <darin at apple.com>  2010-03-14 16:18:11 PST ---
(From update of attachment 50679)
> -    , m_dropEffect("none")
> +    , m_dropEffect("uninitialized")

Why not use the null string instead of "uninitialized"?

Both initializing to null and checking for null are more efficient than
initializing to "uninitialized" and comparing with "uninitialized". Also, I
think null is a pretty clear way to represent a drop effect that has not been
explicitly set; arguably clearer than the string "uninitialized".

> +static DragOperation defaultOperationForDrag(const DragOperation& srcOpMask)

Since DragOperation is a scalar, I think typing it just DragOperation is fine;
it doesn't have to be const DragOperation&.

r=me

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.