[Webkit-unassigned] [Bug 36092] noscript tag should render when @sandbox disables JavaScript

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Mar 14 13:51:17 PDT 2010


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
  Attachment #50664|review?                     |review+
               Flag|                            |

--- Comment #2 from Darin Adler <darin at apple.com>  2010-03-14 13:51:17 PST ---
(From update of attachment 50664)
It's great that you found all six call sites and fixed them. But the test
checks only one or two of them. It would be better to make tests that cover as
many of these as possible.

It might be good to have a comment in the Settings.h header file warning people
away from using the isJavaScriptEnabled function to decide whether JavaScript
is enabled. It's almost always wrong to use that function unless the code is
simply trying to tweak settings. We don't want to make that header too
confusing, but we also don't want anyone adding any new call sites like these.

r=me despite the limited test coverage

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list