[Webkit-unassigned] [Bug 36093] webkitpy: Move modules in webkitpy/ into appropriate sub-packages (master bug)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Mar 14 13:19:45 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=36093





--- Comment #5 from Chris Jerdonek <cjerdonek at webkit.org>  2010-03-14 13:19:45 PST ---
(In reply to comment #4)
> > My initial feeling is that we should try to put modules into the inner-most
> > package in which they are used (thirdparty/ seems to be an exception).  This
> > way a module has to "prove" itself before being moved to the shared package at
> > the root level (i.e. common/).  This will help us limit the size of common/.
> 
> That sounds like a good plan.  We might want to move config and
> networktransaction to common now because we have immediate plans to use them in
> layout_tests.

I assume that would just be config/webkitport.py?  Sounds good, though we might
want to wait on those until the versioning stuff is decided.  It seems like
some people may still want to preserve 2.4 for layout_tests, and
networktransaction and webkitport both currently require 2.5 (for example,
networktransaction imports mechanize, which in turn needs autoinstall).

By the way, how do you feel about renaming webkitport.py to ports.py since it
will be in a webkitpy config/ directory and contain configurations for multiple
ports?  And similarly, networktransaction.py -> transaction.py since it will be
in a net/ directory?  (Just the modules and not the class names within.)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list