[Webkit-unassigned] [Bug 36093] webkitpy: Move modules in webkitpy/ into appropriate sub-packages (master bug)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36093


Chris Jerdonek <cjerdonek at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cjerdonek at webkit.org




--- Comment #3 from Chris Jerdonek <cjerdonek at webkit.org>  2010-03-14 03:07:14 PST ---
(In reply to comment #1)
> Here's a candidate layout:

Here's a suggested revision.  For conciseness, I've left out the
*_references.py and *_unittest.py files, which should go in as siblings of
their corresponding package folders and modules, respectively.

webkitpy/
  common/ <-- contains modules used by more than one root-level package
    infra/
      autoinstall.py <-- after re-landing the rewrite
      executive.py
      logtesting.py
      logutils.py
      user.py
      webkit_logging.py <-- probably should die
    scm/
      changelogs.py
      diff_parser.py
      scm.py <-- should become many files
  layout_tests/
  patch/
    bot/
      patchcollection.py
      queueengine.py
    commands/
    config/
      committers.py
      webkitport.py
    net/ <-- classes that talk to servers
      bugzilla.py
      buildbot.py
      credentials.py
      networktransaction.py
      statusserver.py
    steps/
    comments.py
    grammar.py
    mock_bugzillatool.py <-- wrong name
    multicommandtool.py
    outputcapture.py <-- probably should die
    stepsequence.py
  python24/
    versioning.py
  style/
  thirdparty/
  unittests.py <-- not sure

I tried moving config/, net/, grammar.py, and outputcapture.py into the patch/
folder because they don't seem to be used by non-patch modules.

My initial feeling is that we should try to put modules into the inner-most
package in which they are used (thirdparty/ seems to be an exception).  This
way a module has to "prove" itself before being moved to the shared package at
the root level (i.e. common/).  This will help us limit the size of common/.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.