[Webkit-unassigned] [Bug 36093] New: webkitpy: Move modules in webkitpy/ into appropriate sub-packages (master bug)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Mar 13 16:55:20 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=36093

           Summary: webkitpy: Move modules in webkitpy/ into appropriate
                    sub-packages (master bug)
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: cjerdonek at webkit.org
                CC: eric at webkit.org, abarth at webkit.org,
                    levin at chromium.org, hamaji at chromium.org


This is a master bug for discussion purposes, and because these moves will
probably be spread over more than one patch.

Initial thoughts:

* In the end, we probably want webkitpy/ to contain only the following as
  immediate children:
  - Package folders
  - Their associated *_references.py modules.
  - And perhaps unittests.py.
* webkit-patch specific files can go in webkitpy/patch, as was discussed here:
  https://bugs.webkit.org/show_bug.cgi?id=35499#c9
* Some of the modules used by more than just webkit-patch seem to be--
  - diff_parser
  - scm and its dependencies (changelogs, executive, user, webkit_logging)
* We may want to group the scm-related files into an scm package.
* We might want to explicitly partition off code that needs to work with Python
  2.4 (e.g. into webkitpy/python24).  The version-checking code, for example,
  needs to work with Python 2.4 so we can report a nice error message to Python
  2.4 users.  By separating it off, it will be easier to ensure that this code
does
  not accidentally import code that requires Python 2.5 and break.

Initial questions:

(1) Are the webkitpy/commands and webkitpy/steps packages webkit-patch
    specific?
(2) Aside from patch, scm, and any infra-structure related modules that can
    go in webkitpy/init, do you see any other possibilities for packages that
should
    go immediately under webkitpy?  For example, are there any other
applications
    distinct from webkit-patch that rely on the scm-related code in webkitpy?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list