[Webkit-unassigned] [Bug 34741] MathML Support for mfrac

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Mar 13 10:28:47 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=34741


Kenneth Rohde Christiansen <kenneth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #49951|review?                     |review-
               Flag|                            |




--- Comment #2 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2010-03-13 10:28:47 PST ---
(From update of attachment 49951)

> +    if (lastChild())
> +        if (lastChild()->isRenderBlock()) {
> +            RenderBlock* denominator = toRenderBlock(lastChild());
> +            int previousWidth = denominator->style()->borderTopWidth();
> +            int borderWidth = static_cast<int>(ceil(gFractionBarWidth * style()->fontSize()));
> +            denominator->style()->setBorderTopWidth(previousWidth * borderWidth);
> +        }
> +    
> +    if (previousSibling())
> +        if (previousSibling()->isRenderBlock()) {
> +            RenderBlock* sibling = toRenderBlock(previousSibling());
> +            verticalAlignCompute(sibling);
> +            RenderBlock::layout();
> +            return;
> +        }
> +    if (nextSibling())
> +        if (nextSibling()->isRenderBlock()) {
> +            RenderBlock* sibling = toRenderBlock(nextSibling());
> +            verticalAlignCompute(sibling);
> +        }
> +    

The above is against our coding style. An if with contents (comments included)
spanding more than one line should use {}

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list