[Webkit-unassigned] [Bug 33413] selection.modify extends too far with 'lineboundary'

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33413


Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50565|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #19 from Alexey Proskuryakov <ap at webkit.org>  2010-03-12 13:55:00 PST ---
(From update of attachment 50565)
Code changes look good to me. I have some nits about the comment though.

+            // LineBoundary granularity actually emulates

"Actually" doesn't mean anything here, and can be just omitted.

+            // NSTextView#moveToRightEndOfLineAndModifySelection(),

I don't see such a method in NSTextView. If it were there, it would have been
written as "-[NSTextView moveToRightEndOfLineAndModifySelection:]". But the
important thing is that we try to match NSTextView behavior for user actions,
not the behavior of some low level method.

+            // which never expands a selection across multiple lines.
+            // So we set UPSTREAM affinity to prevent crossing the
+            // line boundary when the offset is at the end of the line.

I don't think this comment is necessary. The behavior is covered by a
regression test, so it's unlikely that someone will break it, and if rationale
for the change is needed in the future, svn blame can always be consulted.

These test has platform/win results, too, and they also need to be updated. I
don't know why these are different, but the expected results file should be
hopefully easy to patch even if you don't have a Windows development
environment.

r=me if this whole comment is removed when landing, and Windows results are
updated. Or you can submit an updated patch for double-checking and commit
queue.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.