[Webkit-unassigned] [Bug 35936] [EFL] Add ewk_view_single.c to WK/efl/ewk

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35936


Kenneth Rohde Christiansen <kenneth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kenneth at webkit.org




--- Comment #4 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2010-03-12 12:44:22 PST ---
(In reply to comment #3)
> Hi Kenneth,
> 
> Yes, we'd like to keep EFL's coding style in the port-specific part under
> WebKit/efl as we expect more EFL hackers will work with it and it's what they
> are used... we should have very few bits of C++ and WebCore access there, so it
> does make sense.

OK, sounds good to me.

> About the variables, it is part of the EFL coding standards. It may make more
> sense to have objectHeight for you, but we're used to oh... Our whole SVN is
> about these, so it's commonly named variables. Yeah, there could be endless
> discussion about this, but if possible we'd like to keep it like that
> (otherwise any patch by Rasterman we'll have to be redone!)

Yes, if that is what you are used to and as this part of WebKit is only used by
you, I think you should keep 'oh' etc. 

> There is no tiling backing store here. 

I believe that the WebCore one landed some time ago with a Qt implementation.
I'm a bit behind on bugzilla emails so I might be wrong.

> We do have one, but it's not being
> upstreamed at this point due various issues, maybe it will go later.  The
> tiling you see here is a rectangle splitter/merger, the same as used in Evas.
> It's duty is to get a list of rectangles, check if they are overlapping and if
> so split into multiple rectangles, if there are nearby rectangles to be merged,
> they are. And this also accounts a fuzzy factor that would allow merging 2
> rectangles even if they don't match an edge perfectly, painting more area in
> trade of performance as if the number of rectangles grows too much, clipping
> will hurt performance.

OK, sounds good.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.