[Webkit-unassigned] [Bug 35877] [Qt] [ rubberstamp!] Fix if statement in Qt Launcher

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 12 10:28:23 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=35877


Kenneth Rohde Christiansen <kenneth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kenneth at webkit.org




--- Comment #4 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2010-03-12 10:28:23 PST ---
 void WebViewGraphicsBased::setFrameRateMeasurementEnabled(bool enabled)
 {
-    if (m_measureFps = enabled) {
+    if (m_measureFps == enabled) {
         m_lastConsultTime = m_startTime = QTime::currentTime();
         m_updateTimer->start();
     } else

This patch is wrong and broke the feature of the launcher.

It attributes enabled to m_messureFpt and then does the if check.

This is the same as 

m_measureFps = enabled;

if (m_measureFps)...

Please revert this patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list