[Webkit-unassigned] [Bug 29847] [Qt] Add support for automatically creating new windows in QWebView

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29847


Kent Hansen <kent.hansen at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|webkit-unassigned at lists.web |webkit-qt-unassigned at trollt
                   |kit.org                     |ech.com
                 CC|                            |kent.hansen at nokia.com




--- Comment #4 from Kent Hansen <kent.hansen at nokia.com>  2010-03-12 08:22:51 PST ---
(In reply to comment #1)
> I disagree that by default we should create new windows. I think this is part
> of the application integrate that needs to be taken care of by the application
> developer. Allowing new top-level  windows coming up by default (that can be
> controlled via JavaScript) sounds like the wrong default to me from a security
> POV.

Creating new windows by default is not what the description suggests.
It suggests adding a property that the default implementation (QWebView) can
check. This property (e.g. autoCreateWindows) would be "false" by default,
preserving the existing behavior.

But regardless of whether this is implemented, the doc for
QWebView::createWindow() should refer to QWebSettings::JavascriptCanOpenWindows
(indeed, the testcase didn't enable this attribute, so createWindow() wasn't
called regardless), and say what the default createWindow() implementation does
(e.g. "always returns 0" or "depends on the autoCreateWindows property").

I'm in favor of just doing the doc update like Simon suggested.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.