[Webkit-unassigned] [Bug 36006] Multiselect popups

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36006





--- Comment #3 from Luiz Agostini <luiz.agostini at openbossa.org>  2010-03-11 22:44:58 PST ---
(In reply to comment #2)
> (From update of attachment 50483 [details])
> We talked about this in IRC:

Very nice talk in IRC. A lot of things got more clear now. Thanks.

> Please use the theme stylesheet mechanism for special appearances. No need for
> nasty hacks in RenderStyle and SelectElement.

For sure theme stylesheet mechanism is much better than making changes in core
classes. However I could not find how to avoid changes in SelectElement. IMHO
it is really needed.

> Eliminate SELECT_ALWAYS_USE_POPUP_MENU ifdef, switch this based on current
> style (Maemo5Style in this case)

I don't want to make this changes enabled in maemo5 right now because if an
special popup implementation is not supplied for <select multiple> then it
makes <select multiple> == <select>.

I am thinking about making this patch completely independent of maemo5 and
create a new bug about maemo5 theme. The patch about maemo5 theme would then
enable multiselect popup, provide the special multiple popup implementation and
make some other theme improvements.

What do you think?

> Casting to WebComboStyleOption is bit nasty. If QStyleOptionComplex is
> insufficient for passing everything, it would be better to subclass it and use
> that subclass everywhere in webkit Qt theme, not just in special case of combo
> box.

Again you are right. However casting is quite common in QStyle and its
subclasses implementations.

QStyleOptionComboBox is an specialization of QStyleOptionComplex used for
comboboxes. It is then not possible avoid special cases for combo boxes because
at least QStyleOptionComboBox is needed. WebComboStyleOption subclasses
QStyleOptionComboBox. With this approach I got:

  1 - QStyle subclasses that are aware of WebComboStyleOption can easily get
the information needed to render special combos.
  2 - special combo rendering naturally falls back to normal combo rendering in
QStyle subclasses that are not aware of WebComboStyleOption.

Do you think it is really too nasty?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.