[Webkit-unassigned] [Bug 35288] [Haiku] Implement ImageBuffer support
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Mar 11 14:52:11 PST 2010
https://bugs.webkit.org/show_bug.cgi?id=35288
David Levin <levin at chromium.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #49273|review? |review-
Flag| |
--- Comment #3 from David Levin <levin at chromium.org> 2010-03-11 14:52:11 PST ---
(From update of attachment 49273)
Just some minor things to address.
> Index: WebCore/platform/graphics/haiku/StillImageHaiku.cpp
> +unsigned StillImage::decodedSize() const
> +{
> + // TODO: It could be wise to return 0 here, since we don't want WebCore
Use FIXME instead of TODO.
> Index: WebCore/platform/graphics/haiku/StillImageHaiku.h
> + virtual void destroyDecodedData(bool = true);
You should put in the parameter name here. I had no idea what the bool for was.
> + StillImage(const BBitmap& bitmap);
You should remove the param name "bitmap" here. as it adds no information.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list