[Webkit-unassigned] [Bug 35992] Crash at MediaPlayer::duration()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35992





--- Comment #7 from Eric Carlson <eric.carlson at apple.com>  2010-03-11 12:37:38 PST ---
(In reply to comment #4)
> (In reply to comment #3)
> > (From update of attachment 50463 [details] [details])
> > >  float HTMLMediaElement::duration() const
> > >  {
> > > -    if (m_readyState >= HAVE_METADATA)
> > > +    if (m_player && m_readyState >= HAVE_METADATA)
> > >          return m_player->duration();
> > 
> > While this is a sensible change, it shouldn't be necessary to prevent this
> > crash because m_readyState should be HAVE_NOTHING if m_player is NULL. I
> > haven't looked, but I suspect there are more problems waiting to be discovered
> > when the the player has been destroyed and the state hasn't been reset.Can you
> > please reset m_readyState and m_networkState to their default values when the
> > player is destroyed?
> 
> The spec actually doesn't say that we should reset m_readyState to default
> value, like HAVE_NOTHING. It specifies how m_networkState should be assigned
> though. Though I think setting m_readyState to HAVE_NOTHING is sensible, but i
> wasn't sure. Any thoughts?
> 
It does though, HAVE_NOTHING is defined as:

No information regarding the media resource is available. No data for the
current playback position is available.

and we have not data at all if the media engine has been destroyed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.