[Webkit-unassigned] [Bug 35747] [GStreamer] Poll messages from the bus if the player is not runned inside a glib mainloop

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35747





--- Comment #8 from Gustavo Noronha (kov) <gns at gnome.org>  2010-03-11 12:18:00 PST ---
(In reply to comment #6)
> (In reply to comment #5)
> > Eric, could you share some thoughts on this? =D
> 
> Well, I know *nothing* about the gtk main loop but I wonder if it is a good
> idea to do this by default, even on Mac in Windows. 

My question is more along the lines of - would it be a problem to add running
the glib main loop along with the win/mac mainloop if you decide to build those
ports with the GStreamer backend included? That would mean adding this call:

    g_main_context_iteration(NULL, FALSE);

To these functions:

[WebCore/platform/mac/EventLoopMac.mm]
void EventLoop::cycle()
{
    // FIXME: Should this use NSRunLoopCommonModes? Switching to
NSRunLoopCommonModes causes Safari to hang in a tight loop.
    [NSApp setWindowsNeedUpdate:YES];
    NSEvent *event = [NSApp nextEventMatchingMask:NSAnyEventMask
untilDate:[NSDate distantFuture] inMode:NSDefaultRunLoopMode dequeue:YES];
    [NSApp sendEvent:event];
}

[WebCore/platform/win/EventLoopWin.cpp]
void EventLoop::cycle()
{
    MSG msg;
    if (!GetMessage(&msg, 0, 0, 0)) {
        m_ended = true;
        return;
    }

    TranslateMessage(&msg);
    DispatchMessage(&msg);
}

> I assume anyone using WebKit with the GStreamer backend in their app will be
> building from source, so why not make it a compile time option?

Yes, build time option defeats runtime choice, IMO.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.