[Webkit-unassigned] [Bug 35762] New port: EFL; adding files to WebCore/plugins/efl (patch 2/2)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35762





--- Comment #3 from Leandro Pereira <leandro at profusion.mobi>  2010-03-10 11:22:59 PST ---
(In reply to comment #2)
> > +X11EmbedContainer::~X11EmbedContainer()
> > +{ (...)
> 
> It would make sense to make m_focusProxy and m_clientWindow OwnPtr here.
> 

Will do.

> > +class X11Info { (...)
> 
> 
> Is there any reason to not have X11Info more static? Currently you will end up
> having
> one instance per plugin, I think having one instance per Screen should be fine?
>

I wouldn't bother with this right now, since WebCore/plugins/efl is scheduled
to be rewritten.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.