[Webkit-unassigned] [Bug 35689] ResourceLoader should call cancel() on ResourceHandle after clearing its client

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35689





--- Comment #13 from Yong Li <yong.li.webkit at gmail.com>  2010-03-10 08:15:00 PST ---
(In reply to comment #12)
> Per comment 6, this fixes crashes on some platforms. Why not make a patch for
> the crash? You may be able to exercise this code by detaching a subframe, or
> just removing an img element.

Yes, we can fix crash in the port where it crashes. But is there any reason why
we don't want to cancel the job at this point? It's hard to verify the behavior
change, but what the small change does is very obvious. There's similar code at
2 places in ApplicationCacheGroup.cpp. Apparently it's very safe.

        m_manifestHandle->setClient(0);
        m_manifestHandle->cancel();
        m_manifestHandle = 0;

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.