[Webkit-unassigned] [Bug 35846] Kill applicationID() (part 1)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35846


Darin Fisher (:fishd, Google) <fishd at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50345|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #9 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2010-03-09 15:53:00 PST ---
(From update of attachment 50345)
> +++ b/WebKit/chromium/public/WebNotificationPresenter.h
...
> +    virtual Permission checkPermission(const WebSecurityOrigin& origin)
> +    {
> +        return PermissionNotAllowed;
> +    };

nit: no trailing semi-colon


> +++ b/WebKit/chromium/src/NotificationPresenterImpl.cpp
...
> +    int result = m_presenter->checkPermission(WebSecurityOrigin(origin));
> +
> +    // FIXME: Remove this once clients are updated to use the above signature.
> +    if (result == NotificationPresenter::PermissionNotAllowed)

nit: you can drop the NotificationPresenter:: prefix here.


> +++ b/WebKit/win/WebCoreSupport/WebDesktopNotificationsDelegate.cpp
> @@ -174,8 +174,13 @@ void WebDesktopNotificationsDelegate::requestPermission(SecurityOrigin* origin,
>  
>  NotificationPresenter::Permission WebDesktopNotificationsDelegate::checkPermission(const KURL& url, Document*)
>  {
> +    return (NotificationPresenter::Permission) 0;

perhaps it would be better to explicitly return one of the enum values?
0 means PermissionAllowed, right?


r=me otherwise.  cq- since there are some nits to fix.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.