[Webkit-unassigned] [Bug 35333] [GTK] video playback position query flood when mouse over the video element

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 9 09:15:07 PST 2010


--- Comment #7 from Gustavo Noronha (kov) <gns at gnome.org>  2010-03-09 09:15:07 PST ---
(In reply to comment #6)
> // Structure that will hold every native
> // types supported by the current media player.
> // We have to do that has multiple media players
> // backend can live at runtime.
> So as I understood it we need to stuff inside this structure. Or should we
> instead conditionally define it depending on the platform? Now I am confused!
> :)

Made sense to me after reading a bit more of the code. No, I think your
original patch is right. This is so that, say, if a port is able to use both
the Mac Media Player, and the GStreamer one, you'll have both available, and
choose which to use in run time.

> > This seems totally unrelated?
> It is not! :) canPlay() triggers a call to endedPlayback() which queries the
> duration. This query is useless, just checking paused() is enough in this
> context and this what MediaControlPlayButtonElement::updateDisplayType does,

Hah. OK, then. I wonder if it makes sense as a separate change, though?

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list