[Webkit-unassigned] [Bug 35796] Accept and bailout NULL widgets in ChromiumBridge

Tue Mar 9 09:00:57 PST 2010

https://bugs.webkit.org/show_bug.cgi?id=35796

--- Comment #9 from anton muhin <antonm at chromium.org>  2010-03-09 09:00:57 PST ---
(In reply to comment #7)
> (From update of attachment 50307 [details])
> > +++ b/LayoutTests/fast/frames/iframe-access-screen-of-deleted.html
> > @@ -0,0 +1,36 @@
> > +<html>
> > +<head>
> > +    <script>
> > +    function accessAttributes(s) {
> > +        var value = 0;
> > +        value = s.height;
> > +        value = s.width;
> > +        value = s.colorDepth;
> > +        value = s.pixelDepth;
> > +        value = s.availLeft;
> > +        value = s.availTop;
> > +        value = s.availHeight;
> > +        value = s.availWidth;
> > +    }
> > +
> > +    function runTests() {
> > +        if (window.layoutTestController)
> > +            layoutTestController.dumpAsText();
> > +            
> > +        var f = document.getElementById('theframe');
> > +        var s = f.contentWindow.screen;
> > +        accessAttributes(s);
> > +
> > +        // Now remove and check that we don't crash.
> > +        f.parentNode.removeChild(f);
> > +        accessAttributes(s);
> > +    }
> > +    </script>
> > +</head>
> > +<iframe id="theframe" src="resources/red.html"></iframe>
> > +<body onload="runTests()">
> > +<div>
> > +This tests that accessing screen attributes doesn't crash even if containing form is removed from the parent.
> 
> nit: "form" -> "frame"

Fixed.

Thanks a lot, Darin.  Could you r+ the last patch as well?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.