[Webkit-unassigned] [Bug 35920] Test for referer information being stripped when the header is removed in willSendRequest

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35920


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50308|review?, commit-queue?      |review+, commit-queue+
               Flag|                            |




--- Comment #13 from Darin Adler <darin at apple.com>  2010-03-09 08:51:03 PST ---
(From update of attachment 50308)
Normally we use the misspelling "referer" only in the actual header name on the
wire and use the normal English word "referrer" everywhere else.

>  #include <JavaScriptCore/JSObjectRef.h>
>  #include <JavaScriptCore/JSRetainPtr.h>
> -#include <wtf/RefCounted.h>
> +
> +#include <set>
>  #include <string>
>  #include <vector>
>  
> +#include <wtf/RefCounted.h>

Normally our includes are in a single paragraph sorted as if by the sort tool,
not separate logical paragraphs.

> +    const std::set<std::string>& clearHeaders = gLayoutTestController->willSendRequestClearHeaders();

Normally we do "using namespace std" in our implementation files rather than
using the "std::" prefix that is required in headers. Unless there's a name
conflict of some sort.

No downside in adding a test, unless it has intermittent failures, so we should
land this. r=me

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.