[Webkit-unassigned] [Bug 33590] [GTK] GObject DOM bindings

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33590





--- Comment #39 from Xan Lopez <xan.lopez at gmail.com>  2010-03-09 08:17:15 PST ---
(In reply to comment #37)
> (From update of attachment 47928 [details])
> I'm surprised that there's so much code in the make files.  I would have
> expected those snippets to be broken out into a separate file somehow.

This might be a good idea, yes.

> 
> In expanding the GDOM bindings, please consider using the generic bindings,
> when possible, to improve maintainability.  The generic bindings don't have
> much in them yet (and certainly nothing that's helpful for this patch), but
> we're hoping to grow them over time.

OK, have to say I haven't really looked into it. Will check how other ports use
it.

> 
> On balance, I think we should take this patch and iterate on this code rather
> than leaving the patch in review forever.

Yep, that's the plan, thank you.

Now I'll check with kov about whether we want to branch for 1.2 before landing
this, which I think is the most sensible thing to do.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.