[Webkit-unassigned] [Bug 34601] [BREWMP] Port Heap::allocateBlock and Heap::freeBlock

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 9 07:32:51 PST 2010


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
  Attachment #48154|review?, commit-queue?      |review-
               Flag|                            |

--- Comment #3 from Adam Barth <abarth at webkit.org>  2010-03-09 07:32:51 PST ---
(From update of attachment 48154)
I would have called addressAligned alignedAddress, but that's just a nit.

To answer Eric's question, the two are different in the case were fastMalloc
returns an unaligned address because

+    addressAligned &= BLOCK_MASK;

changes the address.

This patch is horribly memory inefficient.  It seems to cause JavaScript use
about twice as much memory as necessary.  I'd recommend finding another
strategy to allocate aligned addresses.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list