[Webkit-unassigned] [Bug 35874] [Chromium] Adding touch event routing

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 8 15:18:24 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=35874





--- Comment #5 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2010-03-08 15:18:24 PST ---
(From update of attachment 50247)
> +++ b/WebKit/chromium/src/WebViewImpl.cpp
...
> +#if ENABLE(TOUCH_EVENTS)
> +bool WebViewImpl::touchEvent(const WebTouchEvent& event)
> +{
> +    if (!mainFrameImpl() || !mainFrameImpl()->frameView())
> +        return false;
> +
> +    PlatformTouchEventBuilder touchEventBuilder(
> +        mainFrameImpl()->frameView(), event);
> +
> +    EventHandler* eventHandler = mainFrameImpl()->frame()->eventHandler();
> +    return eventHandler->handleTouchEvent(touchEventBuilder);

nit: it is more common in webkit code to just write this w/o the temporary:

  return
mainFrameImpl()->frame()->eventHandler()->handleTouchEvent(touchEventBuilder);

it is OK that lines exceed 80 chars ;-)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list