[Webkit-unassigned] [Bug 35811] [chromium] need DragImage implementation
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Mar 8 14:29:05 PST 2010
https://bugs.webkit.org/show_bug.cgi?id=35811
Darin Fisher (:fishd, Google) <fishd at chromium.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #50241|review? |review-
Flag| |
--- Comment #12 from Darin Fisher (:fishd, Google) <fishd at chromium.org> 2010-03-08 14:29:05 PST ---
(From update of attachment 50241)
> Index: WebCore/platform/chromium/DragImageChromium.cpp
...
> +#if OS(DARWIN)
> +#include "skia/ext/skia_utils_mac.h"
> +#endif
Can you use CG in the Mac port instead? We should really avoid using
skia/ext in WebCore. It introduces a circular dependency between the
repositories!
> +DragImageRef createDragImageFromImage(Image* image)
> +{
> +#if OS(DARWIN)
> + SkBitmap bitmap = gfx::CGImageToSkBitmap(image->getCGImageRef());
please avoid adding gfx:: namespace stuff to WebCore! that stuff is
chromium only.
> Index: WebKit/chromium/ChangeLog
...
> + * public/WebDragImageRef.h: Added.
> + * src/DragClientImpl.cpp:
> + (WebKit::DragClientImpl::startDrag):
> + * src/WebViewImpl.cpp:
> + (WebKit::WebViewImpl::startDragging):
> + * src/WebViewImpl.h:
is there some other public interface change missing? I don't see
any public API that uses WebDragImageRef.
also, please see WebImage.h to note how things differ between
WEBKIT_USING_SKIA and WEBKIT_USING_CG.
It seems like WebDragImageRef should be made consistent with
WebImage.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list