[Webkit-unassigned] [Bug 35877] New: [Qt] [ rubberstamp!] Fix if statement in Qt Launcher

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35877

           Summary: [Qt] [ rubberstamp!] Fix if statement in Qt Launcher
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Other
        OS/Version: Mac OS X 10.5
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: WebKit Qt
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: robert at webkit.org


Whew, had no luck in getting this rubberstamped, people are busy!

>From fbee4aa7f643ba7ddb9729b82ea33ba1c47f1195 Mon Sep 17 00:00:00 2001          
From: Robert Hogan <robert at webkit.org>                                          
Date: Sun, 7 Mar 2010 12:44:44 +0000                                            
Subject: [PATCH] 2010-03-07  Robert Hogan  <robert at webkit.org>                  

        Reviewed by NOBODY (OOPS!).

        QtLauncher: Fix typo in conditional statement in
                    WebViewGraphicsBased::setFrameRateMeasurementEnabled.

        Reviewed by:

        '=' should be '=='!

        * QtLauncher/webview.cpp:
        (WebViewGraphicsBased::setFrameRateMeasurementEnabled):
---
 WebKitTools/ChangeLog              |   14 ++++++++++++++
 WebKitTools/QtLauncher/webview.cpp |    2 +-
 2 files changed, 15 insertions(+), 1 deletions(-)

diff --git a/WebKitTools/ChangeLog b/WebKitTools/ChangeLog
index 6efbd72..befeab7 100644
--- a/WebKitTools/ChangeLog
+++ b/WebKitTools/ChangeLog
@@ -1,3 +1,17 @@
+2010-03-07  Robert Hogan  <robert at webkit.org>
+
+        Reviewed by NOBODY (OOPS!).
+
+        QtLauncher: Fix typo in conditional statement in
+                    WebViewGraphicsBased::setFrameRateMeasurementEnabled.
+
+        Reviewed by:
+
+        '=' should be '=='!
+
+        * QtLauncher/webview.cpp:
+        (WebViewGraphicsBased::setFrameRateMeasurementEnabled):
+
 2010-03-08  Brady Eidson  <beidson at apple.com>

         Reviewed by NOBODY (but suggested by Steve Falkenburg and fixing a
boneheaded mistake on my part last week)
diff --git a/WebKitTools/QtLauncher/webview.cpp
b/WebKitTools/QtLauncher/webview.cpp
index 9252c89..ba1c9b8 100644
--- a/WebKitTools/QtLauncher/webview.cpp
+++ b/WebKitTools/QtLauncher/webview.cpp
@@ -87,7 +87,7 @@ void WebViewGraphicsBased::resizeEvent(QResizeEvent* event)

 void WebViewGraphicsBased::setFrameRateMeasurementEnabled(bool enabled)
 {
-    if (m_measureFps = enabled) {
+    if (m_measureFps == enabled) {
         m_lastConsultTime = m_startTime = QTime::currentTime();
         m_updateTimer->start();
     } else
--
1.6.3.3

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.