[Webkit-unassigned] [Bug 35146] Support tiled backing store

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35146





--- Comment #31 from Benjamin Poulain <benjamin.poulain at nokia.com>  2010-03-08 10:19:27 PST ---
>From a quick look of the webcore patch:

> #include <QDebug>, #include <QThread>

I guess you can skip those, they probably come from an implementation with
threads.


> #include <QImage>

Shouldn't that be <QPixmap>? QImage is not used in this patch, the tiles are
stored as Pixmaps.


> #if PLATFORM(QT)
> QPixmap* m_buffer;
> QPixmap* m_backBuffer;
> QRegion* m_dirtyRegion;
> #endif

Those are implicitly shared, any particular reason to use pointers?


> typedef IntPoint Coordinate;

Why redefine IntPoint? It is regularly used as such for coordinates.


Good luck to the reviewer, this patch is not trivial :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.