[Webkit-unassigned] [Bug 33759] [iexploder] DoS in Gtk/Qt port on painting text from test=81

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33759


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50192|review?                     |review+
               Flag|                            |




--- Comment #2 from Darin Adler <darin at apple.com>  2010-03-08 08:08:51 PST ---
(From update of attachment 50192)
> +    // Prevent running into a denial of service here. If the stroke width is
> +    // twice the size of the width of the text we will not ask cairo to stroke
> +    // the text. See https://bugs.webkit.org/show_bug.cgi?id=33759.

I don't think this comment or change log entry should refer to "denial of
service"; any crashing bug could be called that, and it's an irritatingly
oblique term for a crash.

You could improve the comment by instead explaining the logic behind the 2X
text width limit (larger widths wouldn't look good anyway?) and stating more
specifically why passing a bad value to Cairo is a problem (it crashes when the
value is so large that something overflows?).

r=me on the code change, though

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.