[Webkit-unassigned] [Bug 35593] [Qt] Add Support for QWebSettings::CaretBrowsingEnabled

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35593





--- Comment #3 from Eric Seidel <eric at webkit.org>  2010-03-05 15:44:41 PST ---
(From update of attachment 49822)
This looks good, but can't we make a Layout test for this?  We have
layoutTestController.overridePreference() these days.  Seems we could make a
simple test to at least validate that your check:
+    // Don't allow editor commands or text insertion for nodes that
+    // cannot edit, unless we are in caret mode.
+    if (!frame->editor()->canEdit() && !(frame->settings() &&
frame->settings()->caretBrowsingEnabled()))
+        return;
+
is correct.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.