[Webkit-unassigned] [Bug 35503] [Qt] Implement Desktop Notifications API for QtWebKit

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35503


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #49705|review?                     |review-
               Flag|                            |




--- Comment #3 from Eric Seidel <eric at webkit.org>  2010-03-05 15:14:16 PST ---
(From update of attachment 49705)
Is this really supposed to return a new one?
#if ENABLE(NOTIFICATIONS)
 436 NotificationPresenter* ChromeClientQt::notificationPresenter() const
 437 {
 438     return new NotificationPresenterClientQt; 
 439 }
 440 #endif

based on that method signature, I woudl expect it to return a reference to one.
 I expect you're leaking here.

Spacing:
void NotificationPresenterClientQt::notificationObjectDestroyed(Notification*
notification)
 92 {
 93       notImplemented();
 94 
 95 }

Spacing:
void NotificationPresenterClientQt::requestPermission(SecurityOrigin* origin,
PassRefPtr<VoidCallback> callback)
 98 {
 99   
 100     if (dumpNotification)

r- for what appears to be a leak (or at least would confuse other developers
into causing a leak).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.