[Webkit-unassigned] [Bug 34683] [Haiku] Implement Path, Gradient and flesh out GraphicsContextHaiku

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34683





--- Comment #15 from Stephan Aßmus <superstippi at gmx.de>  2010-03-05 15:12:39 PST ---
Changing the method names to ref() and deref() in order to use RefPtr, I would
have to add another member to the Path class just for the Haiku platform. This
adds clutter to the common Path.h header and Path objects would be ca couple
bytes bigger on Haiku for no real benefit, IMHO. The only thing I gain is that
I don't have to deref in the Path destructor. To be honest, I don't think this
change is justified. I don't even know if adding a RefPtr<HitTestBitmap> to the
Path class for Haiku is even possible without making the whole HitTestBitmap
class known in the Path.h header.

If you think this change absolutely has to be done in order for the patch to
get the green light, I will of course do it, please just leave a note, I would
not want the patch to remain sitting here. I just thought I'd try to explain
why I think it's better as it is. :-)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.