[Webkit-unassigned] [Bug 35804] svn-apply fails to handle git-generated patches with binary file changes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35804





--- Comment #3 from Eric Seidel <eric at webkit.org>  2010-03-05 14:00:13 PST ---
We just need a better error message.  Your diff is missing the git diff
--binary flag.  So there is no binary data!  Thus svn-apply can't actually
apply the patch.

If you regenerate the diff with git diff --binary or using webkit-patch upload
it will "do the right thing" and svn-apply will work just fine.

svn-apply can handle "git diff --binary" patches, but if you have binary
changes and don't pass --binary,  svn-apply can't handle the patch (because
there is not enough data in the patch!).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.