[Webkit-unassigned] [Bug 35804] New: EWS incorrectly rejects git-generated patches with .checksum files

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35804

           Summary: EWS incorrectly rejects git-generated patches with
                    .checksum files
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: New Bugs
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: jamesr at chromium.org


See the failures from https://bugs.webkit.org/show_bug.cgi?id=25648.  The
failure message is:

Failed to run "['/mnt/git/webkit-chromium-ews/WebKitTools/Scripts/svn-apply',
'--force']" exit_code: 2
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/fast/repaint/slider-thumb-change-height.html
patching file LayoutTests/fast/repaint/slider-update-value.html
patching file
LayoutTests/platform/mac/fast/repaint/slider-thumb-change-height-expected.checksum
patch: **** Only garbage was found in the patch input.
patching file
LayoutTests/platform/mac/fast/repaint/slider-thumb-change-height-expected.txt
patching file
LayoutTests/platform/mac/fast/repaint/slider-update-value-expected.checksum
patch: **** Only garbage was found in the patch input.
patching file
LayoutTests/platform/mac/fast/repaint/slider-update-value-expected.txt
patching file WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file WebCore/rendering/RenderObject.h
patching file WebCore/rendering/RenderSlider.cpp

This is because 'patch' complains that the diffs for the .checksum files are
nothing but garbage.  The diffs look like this:

diff --git
a/LayoutTests/platform/mac/fast/repaint/slider-thumb-change-height-expected.checksum
b/LayoutTests/platform/mac/fast/repaint/slider-thumb-change-height-expected.checksum
new file mode 100644
index 0000000..82cbe9b
--- /dev/null
+++
b/LayoutTests/platform/mac/fast/repaint/slider-thumb-change-height-expected.checksum
@@ -0,0 +1 @@
+6e3355f2ea671c3956c85dcb3b0c97a0
\ No newline at end of file

A patch generated from SVN applies cleanly.  The .checksum portion of this
patch is:

Index:
LayoutTests/platform/mac/fast/repaint/slider-thumb-change-height-expected.checksum
===================================================================
---
LayoutTests/platform/mac/fast/repaint/slider-thumb-change-height-expected.checksum
 (revision 0)
+++
LayoutTests/platform/mac/fast/repaint/slider-thumb-change-height-expected.checksum
 (revision 0)
@@ -0,0 +1 @@
+6e3355f2ea671c3956c85dcb3b0c97a0
\ No newline at end of file

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.