[Webkit-unassigned] [Bug 41295] [Chromium] Add chromium WebMediaPlayer to PlatformMedia

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=41295





--- Comment #2 from Jeremy Orlow <jorlow at chromium.org>  2010-06-30 22:45:57 PST ---
(From update of attachment 59934)
Drive by comments.  No r- because someone else should still take a look at this.


WebCore/platform/graphics/MediaPlayer.h:82
 +          WebKit::WebMediaPlayer* chromiumWebMediaPlayer;
Isn't this a layering violation?

WebKit/chromium/src/WebNode.cpp:188
 +      {
goes on previous line

WebKit/chromium/src/WebNode.cpp:190
 +          return (element->platformMedia()).media.chromiumWebMediaPlayer;
why the ()'s?

WebKit/chromium/public/WebNode.h:109
 +      // 0 if |m_private| is another type.
no need to wrap

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.