[Webkit-unassigned] [Bug 41253] [GTK] Add support for GTK+3

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=41253


Diego Escalante Urrelo <diegoe at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |diegoe at gnome.org




--- Comment #5 from Diego Escalante Urrelo <diegoe at gnome.org>  2010-06-30 21:31:02 PST ---
Xan, I get a FTBFS with gtk3 on master:

  CXX    DerivedSources/webkit/WebKitDOMCSSRule.lo
In file included from ./WebCore/platform/graphics/FloatQuad.h:35,
                 from ./WebCore/dom/Range.h:29,
                 from ./WebCore/platform/gtk/DataObjectGtk.h:26,
                 from ./WebKit/gtk/webkit/webkitprivate.h:51,
                 from DerivedSources/webkit/WebKitDOMCSSRule.cpp:38:
./WebCore/platform/graphics/IntRect.h:51: error: conflicting declaration ‘typedef struct _GdkRectangle GdkRectangle’
/home/diego/gnome/build/include/gtk-3.0/gdk/gdktypes.h:77: error: ‘GdkRectangle’ has a previous declaration as ‘typedef struct cairo_rectangle_int_t GdkRectangle’
make[1]: *** [DerivedSources/webkit/WebKitDOMCSSRule.lo] Error 1
make[1]: se sale del directorio `/home/diego/gnome/WebKit'
make: *** [all] Error 2
*** Error during phase build of WebKit: ########## Error running make   *** [1/1]

The problem is the typedef for GdkRectangle, iirc a small neat trick to avoid headers:

WebCore/platform/graphics/IntRect.h:
#if PLATFORM(WIN)
typedef struct tagRECT RECT;
#elif PLATFORM(QT)
QT_BEGIN_NAMESPACE
class QRect;
QT_END_NAMESPACE
#elif PLATFORM(GTK)
typedef struct _GdkRectangle GdkRectangle;

I fooled around trying to fix it but I failed epically. Changing the typedef to cairo_rectangle_int_t GdkRectangle doesn't help.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.