[Webkit-unassigned] [Bug 38775] rebaseline-chromium-webkit-tests doesn't do diffs right with a Git checkout of WebKit

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38775





--- Comment #12 from Shinichiro Hamaji <hamaji at chromium.org>  2010-06-30 19:09:39 PST ---
(From update of attachment 59986)
Cannot we test diff_for_file?

WebKitTools/Scripts/webkitpy/common/checkout/scm.py:228
 +      def diff_for_file(self, path, optios={}):
Hmm... I'd prefer using keyword arguments for all possible options.

def diff_for_file(self, use_bogus_dir=True, git_cached=True, ...)

so we won't make typo. I think this way is more consistent with other code in this file (see changed_file for example)

By the way, do we really need these options?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.