[Webkit-unassigned] [Bug 41292] [V8]When a NPAPI plugin calls NPN_Evaluate to execute script in browser, if the call is initiated by user, allow the popup

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 30 17:14:33 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=41292





--- Comment #10 from Adam Barth <abarth at webkit.org>  2010-06-30 17:14:33 PST ---
> Thanks, should I upload a new patch which already removed the redundant comment?

Sure, if you like.  You don't need to get it reviewed again.  Uploading a new patch will let us land you patch with the commit-queue.

> By the way, since Chromium has its own DumpRenderTree utilities, this test will break chromium test.
> I will file a chromium bug to implement same logic in Chromium's TestNetscapePlugin on crbug.com and provide a patch to change LayoutTest/platform/chromium/test_expectations.txt in this bug thread after this change is landed. Or maybe I should do this now in this patch. What do you suggest?

You probably should change test_expectations.txt in this patch so that the canary bot won't turn red after landing your patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list