[Webkit-unassigned] [Bug 41236] Autocomplete entries are missing when AutoFill entries are shown in the suggestions popup on Chrome

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=41236





--- Comment #8 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2010-06-30 11:08:21 PST ---
(In reply to comment #7)
> > WebKit/chromium/src/WebFrameImpl.cpp:1967
> >  +      RefPtr<HTMLInputElement> element = inputElement.operator PassRefPtr<HTMLInputElement>();
> > I don't think we should be invoking an operator this way.  Can't you
> > just write it like this:
> > 
> >   RefPtr<HTMLInputElement> element(inputElement);
> > 
> > That should cause inputElement to be implicitly converted to
> > PassRefPtr<HTMLInputElement> to fit the RefPtr constructor.
> > 
> 
> The RefPtr constructor does not allow for implicit construction from a WebInputElement.  So that doesn't work.  The syntax:
> 
>  RefPtr<HTMLInputElement> element = static_cast<PassRefPtr<HTMLInputElement> >(inputElement);
> 
> seems a bit cleaner to me.  But I left it with explicit call to cast operator to match local style at line 1963.

I see.  I'm sad to see that others have been calling the operator explicitly.
That is really not how operators are intended to be used!!

It seems like we should make WebNode's unwrap and constUnwrap methods public.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.