[Webkit-unassigned] [Bug 41385] [chromium] Make the user script API static.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=41385


Darin Fisher (:fishd, Google) <fishd at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #60075|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #5 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2010-06-30 10:03:49 PST ---
(From update of attachment 60075)
WebKit/chromium/src/WebViewImpl.cpp:1976
 +      Vector<String>* patterns = new Vector<String>;
nit: use OwnPtr here?

WebKit/chromium/src/WebViewImpl.cpp:1988
 +      Vector<String>* patterns = new Vector<String>;
nit: use OwnPtr here?

i realize that your code is correct, but if someone ever added an early
return it would suddenly start leaking memory.  plus, i was only able
to convince myself that your code was safe by checking the signature
of addUser{Script,StyleSheet}ToWorld to see that it takes a PassOwnPtr
parameter.

r=me otherwise

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.