[Webkit-unassigned] [Bug 41292] [V8]When a NPAPI plugin calls NPN_Evaluate to execute script in browser, if the call is initiated by user, allow the popup

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 30 08:28:49 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=41292





--- Comment #6 from WebKit Review Bot <webkit.review.bot at gmail.com>  2010-06-30 08:28:49 PST ---
Attachment 60121 did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:983:  Use 0 instead of NULL.  [readability/null] [5]
WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:116:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:118:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:297:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:307:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:383:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:406:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Total errors found: 7 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list