[Webkit-unassigned] [Bug 41129] CSSSelector: Avoid chaining tagHistory of CSSSelector, which causes stack overflow.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=41129





--- Comment #8 from Hayato Ito <hayato at chromium.org>  2010-06-30 00:06:32 PST ---
Thank you for the review.

(In reply to comment #6)
> (From update of attachment 60013 [details])
> WebCore/css/CSSParser.cpp:5106
>  +      const static int maxChainingLength = 2048;
> Is this number OK even for embeded devices where stack would be smaller than PCs?

I think 2048 is dangerous for such devices. I've changed the value from 2048 to 256, which is enough for authors of CSS and has less risk for stack overflow. I am not sure this is best value, but it might be okay.

> 
> WebCore/css/CSSParser.cpp:5106
>  +      const static int maxChainingLength = 2048;
> We usually use "static const", not "const static"

Done

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.