[Webkit-unassigned] [Bug 41345] Parameter names in frame src URLs parsed incorrectly if resembles HTML entity code followed by underscore

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=41345





--- Comment #8 from Adam Barth <abarth at webkit.org>  2010-06-29 18:03:27 PST ---
(In reply to comment #7)
> (From update of attachment 60073 [details])
> > +                        if (entity->code > 255)
> > +                            break;
> 
> What's the meaning of the magic number 255 here? If it was a named constant it could have a name or comment indicating why 255 is the correct number.

I bet it's the characters that fit in Latin-1.  That's how the code in the legacy tokenizer is written (although it only applies that branch to attribute values, which doesn't match the spec or Minefield).

The spec just has a giant table:

http://www.whatwg.org/specs/web-apps/current-work/multipage/named-character-references.html#named-character-references

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.